Empty object not subtype of object with index signature#50013
Closed
ahejlsberg wants to merge 3 commits intomainfrom
Closed
Empty object not subtype of object with index signature#50013ahejlsberg wants to merge 3 commits intomainfrom
ahejlsberg wants to merge 3 commits intomainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at c7b2942. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at c7b2942. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at c7b2942. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at c7b2942. You can monitor the build here. Update: The results are in! |
Collaborator
|
@ahejlsberg Here they are:Comparison Report - main..50013
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Collaborator
|
@ahejlsberg |
ProKashif
approved these changes
Jul 23, 2022
Andarist
reviewed
Jul 23, 2022
Comment on lines
+88
to
+89
| >values3 : any[] | ||
| >Object.values({}) : any[] |
Contributor
There was a problem hiding this comment.
q: is this a desired change?
Member
Author
|
Closing in favor of #50044. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens the subtype relation such that a non-fresh
{}is not considered a subtype of{ [x: string]: xxx }. Currently, such types are subtypes in both directions, which causes issues in narrowing.This fixes the issue reported here.